Fix: remove duplicate word suggestions from multiple dictionaries - #82
Open
0xaaadnf wants to merge 1 commit into
Open
Fix: remove duplicate word suggestions from multiple dictionaries#820xaaadnf wants to merge 1 commit into
0xaaadnf wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where duplicate completion suggestions were returned if the same word existed across multiple dictionary files.
Problem
When multiple dictionary files contain overlapping words, the plugin includes the word as a suggestion for each file it appears in, resulting in duplicate entries in the completion menu.
How to Reproduce
/tmp/dict1.txt
/tmp/dict2.txt
Solution
Added a filtering step using a local set (seen) to deduplicate completion items by label before returning them. blue (and any other repeated word) now appears only once.